On Monday, January 06, 2014 04:43:54 PM Tang Chen wrote: > strncmp() does not check if the params are NULL. In acpi_table_parse(), > if @id is NULL, the kernel will panic. > > Signed-off-by: Tang Chen <tangchen@xxxxxxxxxxxxxx> > Acked-by: Toshi Kani <toshi.kani@xxxxxx> Queued up for 3.14 (but please use the e-mail address from MAINTAINERS next time). Thanks! > --- > drivers/acpi/tables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index d67a1fe..5a5263b 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -293,7 +293,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler) > if (acpi_disabled) > return -ENODEV; > > - if (!handler) > + if (!id || !handler) > return -EINVAL; > > if (strncmp(id, ACPI_SIG_MADT, 4) == 0) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
