On Mon, Dec 16, 2013 at 8:15 AM, Betty Dall <betty.dall@xxxxxx> wrote: > On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote: > >> I should have thought longer before hitting send. I think it's worthwhile >> to use the same helper in aer_hest_parse_aff(), and once I did that, it >> became more obvious that aer_hest_parse() and aer_hest_parse_aff() are >> essentially similar, so I wonder if it's worth consolidating them, as >> below. It doesn't reduce the number of lines of code, but maybe it's >> simpler for the reader? > > > Hi Bjorn, > > That is a nice cleanup. I tested it on my firmware first system. > > Also, I double checked back through the ACPI spec, and there are > FIRMWARE_FIRST flags in the IA-32 Architecture Machine Check Exception > and IA-32 Architecture Corrected Machine Check error sources too. These > functions we are changing are specifically looking just for the AER > error sources. That is correct because AER firmware first is separate > from MCE/CMC firmware first. So, this patch looks good. Thanks, I added your "Reviewed-by". Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
