On Wed, Dec 4, 2013 at 4:38 PM, Hanjun Guo <hanjun.guo@xxxxxxxxxx> wrote: > On 2013年12月04日 01:25, Rob Herring wrote: >> On Tue, Dec 3, 2013 at 10:39 AM, Hanjun Guo <hanjun.guo@xxxxxxxxxx> wrote: >>> >>> From: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> >>> >>> This patch introduces a new API for acpi based irq mapping. >>> >>> [hanjun: Rework this patch to delete the reference to >>> gic_irq_domain_xlate() which can simplify the code a lot.] >>> >>> Signed-off-by: Amit Daniel Kachhap <amit.daniel@xxxxxxxxxxx> >>> Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx> (...) >>> +EXPORT_SYMBOL_GPL(irq_create_acpi_mapping); >> >> There is nothing ACPI specific about this function. This is simply >> irq_create_of_mapping w/o translating of_phandle_args to a hwirq and >> type. So I expect the code to be re-factored here to mirror that. > > Sorry for my bad english, do you mean create a OF free function > and call that from the OF function ? Sounds like a good idea, like if you move the OF function into kernel/irq/irqdomain.c and get rid of the OF specific naming then use that same function from ACPI too. It's all about using the irq_default_domain in a standard way after all right? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
