On Sat, Dec 07, 2013 at 01:36:41PM +0100, Jan Vcelak wrote: > Some degraded batteries report maximal capacity to be smaller than > current charge of the battery. This can confuse some user space > applications (like upower). Can't we just fix upower? > + > + /* Some degraded batteries report lower full charge than current one. */ > + if (battery->capacity_now > battery->full_charge_capacity) > + battery->full_charge_capacity = battery->capacity_now; > + Does upower read *_full on every read of the value? How do we guarantee that it won't read energy_now without updating energy_full and still come up with an incorrect calculation? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
