On Fri, Dec 06, 2013 at 04:51:52PM +0800, Lv Zheng wrote: > Replace direct inclusions of <acpi/acpi.h>, <acpi/acpi_bus.h> and > <acpi/acpi_drivers.h>, which are incorrect, with <linux/acpi.h> > inclusions and remove some inclusions of those files that aren't > necessary. > > First of all, <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> > should not be included directly from any files that are built for > CONFIG_ACPI unset, because that generally leads to build warnings about > undefined symbols in !CONFIG_ACPI builds. For CONFIG_ACPI set, > <linux/acpi.h> includes those files and for CONFIG_ACPI unset it > provides stub ACPI symbols to be used in that case. > > Second, there are ordering dependencies between those files that always > have to be met. Namely, it is required that <acpi/acpi_bus.h> be included > prior to <acpi/acpi_drivers.h> so that the acpi_pci_root declarations the > latter depends on are always there. And <acpi/acpi.h> which provides > basic ACPICA type declarations should always be included prior to any other > ACPI headers in CONFIG_ACPI builds. That also is taken care of including > <linux/acpi.h> as appropriate. > > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx> > Cc: Tony Luck <tony.luck@xxxxxxxxx> > Cc: "H. Peter Anvin" <hpa@xxxxxxxxx> > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> (drivers/pci stuff) > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> .. for the Xen stuff with the assertion that you did build with the right CONFIG_XEN...=y parameters). Thank you! -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
