On Tue, Nov 26, 2013 at 09:29:33PM +0100, Rafael J. Wysocki wrote: > On Tuesday, November 26, 2013 01:21:15 PM Lv Zheng wrote: > > Replace direct inclusions of <acpi/acpi.h>, <acpi/acpi_bus.h> and > > <acpi/acpi_drivers.h>, which are incorrect, with <linux/acpi.h> inclusions. > > > > First of all, <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h> > > should not be included directly from any files that are built for > > CONFIG_ACPI unset, because that generally leads to build warnings about > > undefined symbols in !CONFIG_ACPI builds. For CONFIG_ACPI set, > > <linux/acpi.h> includes those files and for !CONFIG_ACPI it provides stub > > ACPI symbols to be used in that case. > > > > Second, there are ordering dependencies between those files that always > > have to be met. Namely, it is required that <acpi/acpi_bus.h> be included > > prior to <acpi/acpi_drivers.h> so that the acpi_pci_root declarations the > > latter depends on are always there. And <acpi/acpi.h> which provides > > basic ACPICA type declarations should always be included prior to any other > > ACPI headers in CONFIG_ACPI builds. That also is taken care of including > > <linux/acpi.h> as appropriate. > > > > This patch also includes necessary cleanups in the affected files where > > other ACPI headers is also included but not referenced. > > > > This looks OK to me, but it touches several other subsystems. It's better to > CC such things to linux-kernel at least. > > Peter, Matthew, Tony, Konrad, Greg, Bjorn, do you have any objections against this? None from me, nice cleanups. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
