On Mon, Nov 25, 2013 at 11:42:09AM +0530, Naveen N. Rao wrote: > > + > > + /* ensure iff events by strictly check can be handled */ > > Comment can probably be removed - not sure it conveys anything useful. > I think comments are always meaningful only if it is correct. BTW, this comment is used to tell only following two scenarios can be handled properly. > > + if (sec_sev == GHES_SEV_CORRECTED && > > + (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) > > + flags = MF_SOFT_OFFLINE; > > + if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) > > + flags = 0; > > + > > + if (flag != -1) > > Wonder if this even compiles! That should be 'flags'. > I'm sorry for that. I must forget to select CONFIG_ACPI_APEI_MEMORY_FAILURE. Thanks for your careful observation.
Attachment:
signature.asc
Description: Digital signature
