On Fri, Nov 22, 2013 at 12:12:42PM -0600, Brandon Anderson wrote: > + status = acpi_evaluate_object_typed(handle, "_DSM", > + &input, &output, ACPI_TYPE_PACKAGE); We've got enough uses of _DSM that it'd be nice to have a generic helper function for setting them up. Not that this is a blocker. > + /* parse 2 objects per entry */ But if we're expecting anyone to use _DSM for DT properties, this really should be a generic function. Don't make it AMBA specific. > + /* key=value format for clocks is: > + * "clock-name"="apb_pclk \\_SB.CLK0" > + */ > + if (acpi_amba_dsm_lookup(handle, "clock-name", index, &entry) != 0) > + return NULL; Why use DT properties for this? If you're just pointing to something else in the ACPI namespace then add a method that returns the object. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
