On 11/17/2013 03:26 PM, Rafael J. Wysocki wrote:
On Saturday, November 09, 2013 06:36:21 PM al.stone@xxxxxxxxxx wrote:
From: Al Stone <ahs3@xxxxxxxxxx>
I'm reading the patch as "the timer resolution in HW reduced mode is always
32-bit". Is my reading correct?
Whups, I see what I did. You are reading the patch correctly.
However, what the code should ultimately do is ignore the
ACPI_FADT_32BIT_TIMER flag completely. Let me look at where the
timer_resolution field is being used also since it is not immediately
clear what value it should have, or if it should even be used, when
in reduced HW mode.
Signed-off-by: Al Stone <al.stone@xxxxxxxxxx>
---
drivers/acpi/acpica/utxface.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/utxface.c b/drivers/acpi/acpica/utxface.c
index be322c8..fe94b3e 100644
--- a/drivers/acpi/acpica/utxface.c
+++ b/drivers/acpi/acpica/utxface.c
@@ -187,7 +187,8 @@ acpi_status acpi_get_system_info(struct acpi_buffer * out_buffer)
/* Timer resolution - 24 or 32 bits */
- if (acpi_gbl_FADT.flags & ACPI_FADT_32BIT_TIMER) {
+ if (!acpi_gbl_reduced_hardware &&
+ (acpi_gbl_FADT.flags & ACPI_FADT_32BIT_TIMER)) {
info_ptr->timer_resolution = 24;
} else {
info_ptr->timer_resolution = 32;
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@xxxxxxxxxx
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
