On Tue, 2013-11-19 at 12:31 +0100, Peter Zijlstra wrote: > People seem to delight in writing wrong and broken mwait idle routines; > collapse the lot. > > This leaves mwait_play_dead() the sole remaining user of __mwait() and > new __mwait() users are probably doing it wrong. > > Also remove __sti_mwait() as its unused. > > Signed-off-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > --- > > Mike, does this cure your core2? Nope. Maybe an acpi/bios thingy on this box since diags that fired on lappy during boot did not fire on desktop, and both are core2 booting same kernel. I kinda suspect I'll either be stuck with default_idle or have to resurrect mwait_idle and carry it locally if I want the thing to work well. Guess I'll find out if/when I have time to squabble with it. Meanwhile, desktop box works fine modulo benchmarks, lappy works fine too, modulo max_cstate=1 scaring mwait_idle_with_hints away, which I don't care about much. Neither box is wonderful at rt testing where I usually boot max_cstate=1, both just became a bit _less_ wonderful :) -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
