On Thu, Oct 10, 2013 at 09:12:56AM +0300, Mika Westerberg wrote: > On Wed, Oct 09, 2013 at 06:55:28PM +0100, Mark Brown wrote: > > On Wed, Oct 09, 2013 at 05:04:21PM +0300, Mika Westerberg wrote: > > > + if (ACPI_HANDLE(&spi->dev)) > > > + acpi_dev_pm_attach(&spi->dev, true); > > Though I do wonder if it wouldn't be sensible to push the if () here > > inside acpi_dev_pm_attach() and similarly for _detach(). Terribly > > trivial either way. > Actually, the check is already there in acpi_dev_pm_attach()/detach(). The > above code follows what Rafael did for platform bus previously. I think the > idea is to have visual hint that this is only for ACPI enumerated devices. > If preferred, I can drop the if() checks, though. It'd seem neater - the fact that the function is acpi_ ought to be enough of a hint.
Attachment:
signature.asc
Description: Digital signature
