Re: [PATCH] ACPICA: Silent warnings about empty body in if/else statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, October 07, 2013 07:08:00 PM Jean Delvare wrote:
> Le Monday 07 October 2013 à 14:11 +0200, Rafael J. Wysocki a écrit :
> > On Monday, October 07, 2013 11:45:01 AM Jean Delvare wrote:
> > > When ACPI debugging is disabled, I see warnings like this one:
> > > 
> > > drivers/i2c/busses/i2c-scmi.c: In function "acpi_smbus_cmi_add_cap":
> > > drivers/i2c/busses/i2c-scmi.c:328:39: warning: suggest braces around empty body in an "else" statement [-Wempty-body]
> > > drivers/i2c/busses/i2c-scmi.c:338:12: warning: suggest braces around empty body in an "else" statement [-Wempty-body]
> > > 
> > > It is caused by ACPI_DEBUG_PRINT (or other similar macros) to resolve
> > > to nothing. Make them resolve to the classic "do {} while (0)" construct
> > > instead when the compiler likes that, to silent all such warnings.
> > 
> > The rule is that ACPICA patches need to go via upstream ACPICA, so I CCed
> > the ACPICA maintainers.
> 
> Thanks Rafael. Maybe MAINTAINERS should be adjusted accordingly.
> Contributors can't guess.

That actually is a good idea.  I think we'll do that.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux