On 09/18/2013 08:36 PM, Igor Gnatenko wrote: > On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote: >> On 09/18/2013 02:30 PM, Igor Gnatenko wrote: >>> On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: >>>> On 09/17/2013 09:34 PM, Igor Gnatenko wrote: >>>>> >>>>> Aaron, how about fix indicator on ThinkPads ? >>>> >>>> Can you please describe the problem in detail, is it that when you >>>> adjust brightness level through hotkey, there is no GUI indication? >>>> Thanks. >>>> >>>> -Aaron >>> >>> Yes. On my ThinkPad X230 I pressing backlight hotkeys. Actually >>> brightnes changing, but have no indicator in GUI. >> >> Oh, that's still the problem of _BCL not getting executed once for >> Lenovo thinkpad laptops. I borrowed a Thinkpad X1 this afternoon and can >> reproduce this, I'll take a look at this issue. The thinkpad-acpi module >> already has a call to _BCL but somehow that doesn't happen. >> >> Since it's national holidays here, I'll check this issue when I got back >> to work on this Saturday. Thanks for the quick test :-) > Thanks. No problem ;-) Here is a quick fix for thinkpad-acpi.c: https://github.com/aaronlu/linux acpi_video_win8 commit thinkpad-acpi: fix handle locate for video and query of _BCL. Note that it is a separate issue specifically for thinkpad so I'll submit that patch in another thread. Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html