Re: [PATCH 06/14] ACPICA: Validate start object for acpi_walk_namespace.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This was filed an fixed very quickly.
Is it something we see in the field?
The patch is small, should we mark it for -stable?

thanks

On Thu, Sep 12, 2013 at 4:55 AM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote:
> From: Bob Moore <robert.moore@xxxxxxxxx>
>
> Perform a sanity check on the start object to prevent problems
> later. ACPICA BZ 1025.
>
> Buglink: http://bugs.acpica.org/show_bug.cgi?id=1025
> Signed-off-by: Bob Moore <robert.moore@xxxxxxxxx>
> Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> ---
>  drivers/acpi/acpica/nsxfeval.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c
> index b38b4b0..481a6b4 100644
> --- a/drivers/acpi/acpica/nsxfeval.c
> +++ b/drivers/acpi/acpica/nsxfeval.c
> @@ -605,11 +605,19 @@ acpi_walk_namespace(acpi_object_type type,
>                 goto unlock_and_exit;
>         }
>
> +       /* Now we can validate the starting node */
> +
> +       if (!acpi_ns_validate_handle(start_object)) {
> +               status = AE_BAD_PARAMETER;
> +               goto unlock_and_exit2;
> +       }
> +
>         status = acpi_ns_walk_namespace(type, start_object, max_depth,
>                                         ACPI_NS_WALK_UNLOCK,
>                                         descending_callback, ascending_callback,
>                                         context, return_value);
>
> +      unlock_and_exit2:
>         (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
>
>        unlock_and_exit:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux