On Thu, 2013-09-12 at 13:00 +0800, Tang Chen wrote: > Hi Rafael, Toshi, > > When we hot-add an ACPI0004 device, we got the following warning: > > acpi ACPI0004:01: Attempt to re-insert > > The ACPI0004 device is a System Board in Fujitsu server, which has two > numa nodes (processors and memory). > > It seems that we reserved the ACPI_NOTIFY_DEVICE_CHECK event twice in > acpi_hotplug_notify_cb(). > > > According to bisect, this happens after the following commit: > > From 68a67f6c78b80525d9b3c6672e7782de95e56a83 Mon Sep 17 00:00:00 2001 > From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx> > Date: Sun, 3 Mar 2013 23:05:55 +0100 > Subject: [PATCH 1/1] ACPI / container: Use common hotplug code > > Switch the ACPI container driver to using common device hotplug code > introduced previously. This reduces the driver down to a trivial > definition and registration of a struct acpi_scan_handler object. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Acked-by: Toshi Kani <toshi.kani@xxxxxx> > Tested-by: Toshi Kani <toshi.kani@xxxxxx> > --- > drivers/acpi/container.c | 146 > ++++------------------------------------------- > 1 file changed, 10 insertions(+), 136 deletions(-) > > > I'm now investigating this problem. If you have any idea about why this > happens, please let me know. With the above change, container devices use the common notify handler, which logs the warning message in question when it receives device check twice on a same device. Before the change, the container-specific notify handler did not log this message in the same case (but considered it as an eject request). So, I suspect that you are getting device check twice regardless of the kernel change. Can you check KERN_DEBUG messages to see if that is the case? The notify handler logs all events with KERN_DEBUG. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
