[+cc Russell] On 22 August 2013 21:45, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > [+cc linux-kernel] > > On Thu, Aug 22, 2013 at 1:44 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >> __initdata should be placed between the variable name and equal >> sign for the variable to be placed in the intended section. > > I'm not sure this is true, or maybe there's some sort of toolchain > issue. On my system, I see the same section placement for > acpi_pnp_bus whether your patch is applied or not: I am not sure why this is so. The init.h header file clearly mentions where the annotation needs to be placed. Also, please see the discussion about it here: http://permalink.gmane.org/gmane.linux.ports.arm.kernel/258149 > > $ objdump -t drivers/pnp/pnpacpi/core.o | grep acpi_pnp_bus > ... > 0000000000000020 l O .init.data 0000000000000038 acpi_pnp_bus > $ cc -v > Using built-in specs. > COLLECT_GCC=/usr/bin/gcc-4.6.real > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.6/lto-wrapper > Target: x86_64-linux-gnu > Configured with: ../src/configure -v > --with-pkgversion='Ubuntu/Linaro 4.6.3-1ubuntu5' > --with-bugurl=file:///usr/share/doc/gcc-4.6/README.Bugs > --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr > --program-suffix=-4.6 --enable-shared --enable-linker-build-id > --with-system-zlib --libexecdir=/usr/lib --without-included-gettext > --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.6 > --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu > --enable-libstdcxx-debug --enable-libstdcxx-time=yes > --enable-gnu-unique-object --enable-plugin --enable-objc-gc > --disable-werror --with-arch-32=i686 --with-tune=generic > --enable-checking=release --build=x86_64-linux-gnu > --host=x86_64-linux-gnu --target=x86_64-linux-gnu > Thread model: posix > gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) > > > If we *do* need a change like this, it looks like there are dozens or > hundreds of similar errors in other places, e.g.: > > Documentation/pinctrl.txt:static struct pinctrl_map __initdata pinmap[] = { > arch/arm/common/mcpm_platsmp.c:static struct smp_operations > __initdata mcpm_smp_ops = { > arch/tile/mm/init.c:static int __initdata ktext_hash = 1; /* .text pages */ > > and they should all be changed at once, maybe with a Coccinelle script. Makes sense. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
