On Wed, Jul 24, 2013 at 10:39 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, Jul 24, 2013 at 12:39 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: >> >> Well, there seems to be a number of people who'll be equally unhappy if I don't >> do that. Unfortunately for you, things work for them without that patch. > > So I think we have to revert the behavior back, but I wonder if we > could keep the logic and have a i915 kernel command line option to > enable it. > > We did that for a long time with "drm.modeset" and the > "i915.enable_rc6" mess. We still have the "i915.invert_brightness" > thing, although I don't know who actually uses it. But that option is > itself an indication that the i915 driver still has some backlight > issues. invert_brighntess seems to be real, at least we have a pile of quirk entries for Acer and Packard Bell machines. Generally I'm not too happy with module options since they tend to get stuck eternally in a limbo state where everyone in the know sets them to their liking and no one bothers to fix the underlying. Otoh this is the backlight and I've essentially given up and opted for quirk entries :( > But if that kind of "revert behavior" isn't easy, we need to just > revert the patches entirely. I think a i915 module option should be doable, otoh people seem to have a viable workaround by setting a different acpi os version already. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
