On Thursday, June 27, 2013 06:37:35 PM Naresh Bhat wrote:
> Hi Rafael,
>
> You mean I need to initialize using ACPI_STATE_D0 ? and resend the patch ?
Yes, please.
Although this is a false positive anyway ...
Thanks,
Rafael
> On 27 June 2013 17:58, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > On Thursday, June 27, 2013 04:38:34 PM naresh.bhat@xxxxxxxxxx wrote:
> >> From: Naresh Bhat <naresh.bhat@xxxxxxxxxx>
> >>
> >> CC drivers/acpi/fan.o
> >> drivers/acpi/fan.c: In function ‘fan_get_cur_state’:
> >> drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized]
> >> ---
> >> drivers/acpi/fan.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> >> index f815da8..f61f7fd 100644
> >> --- a/drivers/acpi/fan.c
> >> +++ b/drivers/acpi/fan.c
> >> @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
> >> {
> >> struct acpi_device *device = cdev->devdata;
> >> int result;
> >> - int acpi_state;
> >> + int acpi_state = 0;
> >
> > Please use an appropriate symbol here.
> >
> >>
> >> if (!device)
> >> return -EINVAL;
> >>
> >
> > Thanks,
> > Rafael
> >
> >
> > --
> > I speak only for myself.
> > Rafael J. Wysocki, Intel Open Source Technology Center.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
