Re: [PATCH] Acpi: acpica: acmacros: fixed a semicolon formatting issue.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, June 18, 2013 08:17:40 PM John B. Wyatt IV wrote:
> From: "John B. Wyatt IV" <sageofredondo@xxxxxxxxx>
> 
> Formatting patch: fixes all "space required after that ';'" errors in
> acmarcos.h.

That code comes from the ACPICA project and doesn't follow the usual Linux
kernel coding style.

> Please note this only fixes 12 out of 64 errors as reported by
> ./scripts/checkpatch.pl

Please do not run this on files under drivers/acpi/acpica/.

Thanks,
Rafael


> ---
>  drivers/acpi/acpica/acmacros.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/acmacros.h b/drivers/acpi/acpica/acmacros.h
> index 53666bd..b916eed 100644
> --- a/drivers/acpi/acpica/acmacros.h
> +++ b/drivers/acpi/acpica/acmacros.h
> @@ -93,15 +93,15 @@
>  /* 16-bit source, 16/32/64 destination */
>  
>  #define ACPI_MOVE_16_TO_16(d, s)        {((  u8 *)(void *)(d))[0] = ((u8 *)(void *)(s))[1];\
> -			  ((  u8 *)(void *)(d))[1] = ((u8 *)(void *)(s))[0];}
> +			  ((  u8 *)(void *)(d))[1] = ((u8 *)(void *)(s))[0]; }
>  
>  #define ACPI_MOVE_16_TO_32(d, s)        {(*(u32 *)(void *)(d))=0;\
>  					  ((u8 *)(void *)(d))[2] = ((u8 *)(void *)(s))[1];\
> -					  ((u8 *)(void *)(d))[3] = ((u8 *)(void *)(s))[0];}
> +					  ((u8 *)(void *)(d))[3] = ((u8 *)(void *)(s))[0]; }
>  
>  #define ACPI_MOVE_16_TO_64(d, s)        {(*(u64 *)(void *)(d))=0;\
>  							   ((u8 *)(void *)(d))[6] = ((u8 *)(void *)(s))[1];\
> -							   ((u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[0];}
> +							   ((u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[0]; }
>  
>  /* 32-bit source, 16/32/64 destination */
>  
> @@ -110,13 +110,13 @@
>  #define ACPI_MOVE_32_TO_32(d, s)        {((  u8 *)(void *)(d))[0] = ((u8 *)(void *)(s))[3];\
>  									  ((  u8 *)(void *)(d))[1] = ((u8 *)(void *)(s))[2];\
>  									  ((  u8 *)(void *)(d))[2] = ((u8 *)(void *)(s))[1];\
> -									  ((  u8 *)(void *)(d))[3] = ((u8 *)(void *)(s))[0];}
> +									  ((  u8 *)(void *)(d))[3] = ((u8 *)(void *)(s))[0]; }
>  
>  #define ACPI_MOVE_32_TO_64(d, s)        {(*(u64 *)(void *)(d))=0;\
>  										   ((u8 *)(void *)(d))[4] = ((u8 *)(void *)(s))[3];\
>  										   ((u8 *)(void *)(d))[5] = ((u8 *)(void *)(s))[2];\
>  										   ((u8 *)(void *)(d))[6] = ((u8 *)(void *)(s))[1];\
> -										   ((u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[0];}
> +										   ((u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[0]; }
>  
>  /* 64-bit source, 16/32/64 destination */
>  
> @@ -131,7 +131,7 @@
>  										 ((  u8 *)(void *)(d))[4] = ((u8 *)(void *)(s))[3];\
>  										 ((  u8 *)(void *)(d))[5] = ((u8 *)(void *)(s))[2];\
>  										 ((  u8 *)(void *)(d))[6] = ((u8 *)(void *)(s))[1];\
> -										 ((  u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[0];}
> +										 ((  u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[0]; }
>  #else
>  /*
>   * Macros for little-endian machines
> @@ -169,10 +169,10 @@
>  /* 16-bit source, 16/32/64 destination */
>  
>  #define ACPI_MOVE_16_TO_16(d, s)        {((  u8 *)(void *)(d))[0] = ((u8 *)(void *)(s))[0];\
> -										 ((  u8 *)(void *)(d))[1] = ((u8 *)(void *)(s))[1];}
> +										 ((  u8 *)(void *)(d))[1] = ((u8 *)(void *)(s))[1]; }
>  
> -#define ACPI_MOVE_16_TO_32(d, s)        {(*(u32 *)(void *)(d)) = 0; ACPI_MOVE_16_TO_16(d, s);}
> -#define ACPI_MOVE_16_TO_64(d, s)        {(*(u64 *)(void *)(d)) = 0; ACPI_MOVE_16_TO_16(d, s);}
> +#define ACPI_MOVE_16_TO_32(d, s)        {(*(u32 *)(void *)(d)) = 0; ACPI_MOVE_16_TO_16(d, s); }
> +#define ACPI_MOVE_16_TO_64(d, s)        {(*(u64 *)(void *)(d)) = 0; ACPI_MOVE_16_TO_16(d, s); }
>  
>  /* 32-bit source, 16/32/64 destination */
>  
> @@ -181,9 +181,9 @@
>  #define ACPI_MOVE_32_TO_32(d, s)        {((  u8 *)(void *)(d))[0] = ((u8 *)(void *)(s))[0];\
>  										 ((  u8 *)(void *)(d))[1] = ((u8 *)(void *)(s))[1];\
>  										 ((  u8 *)(void *)(d))[2] = ((u8 *)(void *)(s))[2];\
> -										 ((  u8 *)(void *)(d))[3] = ((u8 *)(void *)(s))[3];}
> +										 ((  u8 *)(void *)(d))[3] = ((u8 *)(void *)(s))[3]; }
>  
> -#define ACPI_MOVE_32_TO_64(d, s)        {(*(u64 *)(void *)(d)) = 0; ACPI_MOVE_32_TO_32(d, s);}
> +#define ACPI_MOVE_32_TO_64(d, s)        {(*(u64 *)(void *)(d)) = 0; ACPI_MOVE_32_TO_32(d, s); }
>  
>  /* 64-bit source, 16/32/64 destination */
>  
> @@ -196,7 +196,7 @@
>  										 ((  u8 *)(void *)(d))[4] = ((u8 *)(void *)(s))[4];\
>  										 ((  u8 *)(void *)(d))[5] = ((u8 *)(void *)(s))[5];\
>  										 ((  u8 *)(void *)(d))[6] = ((u8 *)(void *)(s))[6];\
> -										 ((  u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[7];}
> +										 ((  u8 *)(void *)(d))[7] = ((u8 *)(void *)(s))[7]; }
>  #endif
>  #endif
>  
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux