This one is just adding additional checks on the _CST that are obvious errors in the AML. The eventual goal of the "repair" code in ACPICA is to never return a bad package from things like _CST. In other words, an AE_OK guarantees that the return value is usable. So, this is an additional implementation of this longer-range project. > -----Original Message----- > From: lenb417@xxxxxxxxx [mailto:lenb417@xxxxxxxxx] On Behalf Of Len Brown > Sent: Wednesday, June 12, 2013 11:00 AM > To: Zheng, Lv > Cc: Wysocki, Rafael J; Moore, Robert; Brown, Len; linux acpi > Subject: Re: [PATCH 15/16] ACPICA: _CST repair: Handle null package > entries > > On Fri, Jun 7, 2013 at 9:01 PM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote: > > Sort package only after null/bad elements have been removed. > > Lv Zheng. > > > again, please explain WHY. > > Every line of change to the kernel adds risk. > I see no justification in this commit message why any risk should be added > to the kernel. > > Nacked-by: Len Brown <len.brown@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html