On Wed, Jun 05, 2013 at 10:17:35AM +0800, Wei Yongjun wrote:
> Date: Wed, 5 Jun 2013 10:17:35 +0800
> From: Wei Yongjun <weiyj.lk@xxxxxxxxx>
> To: lenb@xxxxxxxxxx, rjw@xxxxxxx, gong.chen@xxxxxxxxxxxxxxx,
> tony.luck@xxxxxxxxx
> Cc: yongjun_wei@xxxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx
> Subject: [PATCH] ACPI / APEI: fix error return code in einj_init()
>
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return -ENOMEM in the debugfs_create_xxx() error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
> drivers/acpi/apei/einj.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index 9a47d85..9d60bdd 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -732,6 +732,7 @@ static int __init einj_init(void)
> if (rc)
> goto err_release;
>
> + rc = -ENOMEM;
> einj_param = einj_get_parameter_address();
> if ((param_extension || acpi5) && einj_param) {
> fentry = debugfs_create_x64("param1", S_IRUSR | S_IWUSR,
>
OK to me.
Reviewed-by: Chen Gong <gong.chen@xxxxxxxxxxxxxxx>
Attachment:
signature.asc
Description: Digital signature
