On Thu, Apr 4, 2013 at 11:07 AM, Tejun Heo <tj@xxxxxxxxxx> wrote: >> >> Also move down two functions declaration to avoid #ifdef in setup.c >> >> ACPI_INITRD_TABLE_OVERRIDE depends one ACPI and BLK_DEV_INITRD. >> So could move declaration out from #ifdef CONFIG_ACPI protection. > > Heh, I couldn't really follow the above. How about something like the > following. > > While a dummy version of acpi_initrd_override() was defined when > !CONFIG_ACPI_INITRD_TABLE_OVERRIDE, the prototype and dummy version > were conditionalized inside CONFIG_ACPI. This forced setup_arch() to > have its own #ifdefs around acpi_initrd_override() as otherwise build > would fail when !CONFIG_ACPI. Move the prototypes and dummy > implementations of the newly split functions below CONFIG_ACPI block > in acpi.h so that we can do away with #ifdefs in its user. update changelog with your changes. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html