> -----Original Message----- > From: linux-acpi-owner@xxxxxxxxxxxxxxx [mailto:linux-acpi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Masatake YAMATO > Sent: Thursday, March 21, 2013 3:38 PM > To: linux-acpi@xxxxxxxxxxxxxxx > Cc: yamato@xxxxxxxxxx > Subject: [PATCH] thermal: shorten too long mcast group name > > You will see garbage at the end of line in the output of following command > line: > > $ genl ctrl show | grep thermal_mc_group > #1: ID-0x2 name: thermal_mc_group^B Agreed. > > The type of structure field for "name" is char[16] in the kernel: > > #define GENL_NAMSIZ 16 /* length of family name */ > ... > struct genl_multicast_group { > ... > char name[GENL_NAMSIZ]; > ... > }; > > strlen("thermal_mc_group") == 16 is too long for the array size. > > "thermal_mc_grp" is more readable than "thermal_mc_grou". However, > I choose latter; the patch for genl command side may truncate the > last char in the name: I prefer we use thermal_mc_grp. + Adding Rui & the Linux-pm list. Thanks, Durga > > http://marc.info/?l=linux-netdev&m=136371412625262&w=2 > > Signed-off-by: Masatake YAMATO <yamato@xxxxxxxxxx> > --- > include/linux/thermal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index f0bd7f9..a65dff3 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -44,7 +44,7 @@ > /* Adding event notification support elements */ > #define THERMAL_GENL_FAMILY_NAME "thermal_event" > #define THERMAL_GENL_VERSION 0x01 > -#define THERMAL_GENL_MCAST_GROUP_NAME > "thermal_mc_group" > +#define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_grou" > > /* Default Thermal Governor */ > #if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE) > -- > 1.7.11.7 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
