The excerpt like this:
if (err) {
err = 0;
goto error_out;
}
makes a reader confused even if it's commented. Let's do necessary actions and
return no error explicitly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/acpi/acpi_lpss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index c695841..5d7ded2 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -152,8 +152,8 @@ static int acpi_lpss_create_device(struct acpi_device *adev,
* Skip the device, but don't terminate the namespace
* scan.
*/
- ret = 0;
- goto err_out;
+ kfree(pdata);
+ return 0;
}
}
--
1.8.2.rc0.22.gb3600c3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
