Kernel style uses parenthesis around sizeof. Commit 66c80b60 has already added such check in the scripts/checkpatch.pl. Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx> --- drivers/base/power/sysfs.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/base/power/sysfs.c b/drivers/base/power/sysfs.c index 50d16e3..f089b80 100644 --- a/drivers/base/power/sysfs.c +++ b/drivers/base/power/sysfs.c @@ -119,9 +119,9 @@ static ssize_t control_store(struct device * dev, struct device_attribute *attr, if (cp) len = cp - buf; device_lock(dev); - if (len == sizeof ctrl_auto - 1 && strncmp(buf, ctrl_auto, len) == 0) + if (len == sizeof(ctrl_auto - 1) && strncmp(buf, ctrl_auto, len) == 0) pm_runtime_allow(dev); - else if (len == sizeof ctrl_on - 1 && strncmp(buf, ctrl_on, len) == 0) + else if (len == sizeof(ctrl_on - 1) && strncmp(buf, ctrl_on, len) == 0) pm_runtime_forbid(dev); else n = -EINVAL; @@ -321,11 +321,11 @@ wake_store(struct device * dev, struct device_attribute *attr, cp = memchr(buf, '\n', n); if (cp) len = cp - buf; - if (len == sizeof enabled - 1 - && strncmp(buf, enabled, sizeof enabled - 1) == 0) + if (len == sizeof(enabled - 1) + && strncmp(buf, enabled, sizeof(enabled - 1)) == 0) device_set_wakeup_enable(dev, 1); - else if (len == sizeof disabled - 1 - && strncmp(buf, disabled, sizeof disabled - 1) == 0) + else if (len == sizeof(disabled - 1) + && strncmp(buf, disabled, sizeof(disabled - 1)) == 0) device_set_wakeup_enable(dev, 0); else return -EINVAL; @@ -546,9 +546,9 @@ static ssize_t async_store(struct device *dev, struct device_attribute *attr, cp = memchr(buf, '\n', n); if (cp) len = cp - buf; - if (len == sizeof enabled - 1 && strncmp(buf, enabled, len) == 0) + if (len == sizeof(enabled - 1) && strncmp(buf, enabled, len) == 0) device_enable_async_suspend(dev); - else if (len == sizeof disabled - 1 && strncmp(buf, disabled, len) == 0) + else if (len == sizeof(disabled - 1) && strncmp(buf, disabled, len) == 0) device_disable_async_suspend(dev); else return -EINVAL; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
