Re: [PATCH v5 1/2] TTY: Add TTY slave enumeration support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 24, 2013 at 06:30:21PM +0800, Lv Zheng wrote:
> +static void tty_slave_release(struct device *dev)
> +{
> +	struct tty_slave *tts = to_tty_slave(dev);
> +
> +	kfree(tts);
> +	/* Test code to see if slave device get released */
> +	BUG();
> +}

You send me a patch like this and expect me to apply it when it's
obvious you didn't even test it out?  That's the most _basic_ test for
any dynamic type of device (add it and remove it and make sure the
kernel still works.)  And obviously you didn't do it.

I need a really good reason why to take you seriously now.

Intel kernel developers who know better, please take this internally and
review it a bunch of times, I don't want to see it anytime soon again.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux