On Mon, Jan 21, 2013 at 02:06:27PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > The most convenient way to expose ACPI power resources lists of a > device is to put symbolic links to sysfs directories representing > those resources into special attribute groups in the device's sysfs > directory. For this purpose, it is necessary to be able to add > symbolic links to attribute groups. > > For this reason, add sysfs helper functions for adding/removing > symbolic links to/from attribute groups, sysfs_add_link_to_group() > and sysfs_remove_link_from_group(), respectively. Those functions are fine, but why sysfs_add_link()? It looks identical to sysfs_create_link(), why would you call one and not the other? Why would anything outside of the sysfs core code ever have a pointer to a sysfs_dirent? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
