On Mon, Jan 14, 2013 at 01:01:47PM -0500, Jeff Garzik wrote: > On 01/11/2013 01:44 PM, Tejun Heo wrote: > >Hello, > > > >On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote: > >>OK, will make it atomic in next version, thanks for the advice. > >> > >>Perhaps I can add two scsi helper functions in scsi_lib.c like: > >> > >>void sdev_disable_disk_events(struct scsi_device *sdev) > >>{ > >> atomic_inc(&sdev->disk_events_disable_depth); > >>} > >> > >>void sdev_enable_disk_events(struct scsi_device *sdev) > >>{ > >> if (WARN_ON_ONCE(atomic_read(&sdev->disk_events_disable_depth) <= 0)) > >> return; > >> atomic_dec(&sdev->disk_events_disable_depth); > >>} > >> > >>And call them in ATA layer. Do you like this? > > > >Sounds good to me. James, how does the series look to you? > > Indeed. Want James' Acked-by for patch #1. > > I think it's ready. It can go into libata-dev.git #upstream, and be > reverted prior to Linus push if James NAKs. Great! Thanks. I'll incorporate Tejun's suggestions into v13 and send them out soon. -Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html