On Sat, Jan 12, 2013 at 2:40 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > On Friday, January 11, 2013 02:40:34 PM Yinghai Lu wrote: >> Current all acpi_bus_trim callers have rmdevice to 1. >> that means it will remove all acpi devices. >> >> When 0, is passed, it will keep the parent. >> >> For root bus hotremove support, we need to have pci device to be >> removed before acpi devices. >> >> So try to keep all acpi devices, and only stop drivers with them. >> >> This change should be safe because all current callers all have 1 passed. > > I'm not sure how the chanelog is related to the patch itself. > > The patch modifies the behavior of acpi_bus_trim() to avoid removing all > devices (not just the start point) for rmdevice==0, which doesn't really change > the functionality, because all callers pass rmdevice=1 anyway. > > Yes, we can make this change, but why is it necessary? > > And why don't we remove the rmdevice argument from acpi_bus_trim() altogether? this patch is not needed after your changes with acpi_bus_trim. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
