On Sun, Dec 16, 2012 at 02:32:06PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Since the return value of acpi_bus_get_device() is not of type > acpi_status, ACPI_SUCCESS() should not be used for checking its > return value. Fix that. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > --- > drivers/acpi/device_pm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Index: linux/drivers/acpi/device_pm.c > =================================================================== > --- linux.orig/drivers/acpi/device_pm.c > +++ linux/drivers/acpi/device_pm.c > @@ -358,8 +358,7 @@ static struct acpi_device *acpi_dev_pm_g > acpi_handle handle = DEVICE_ACPI_HANDLE(dev); > struct acpi_device *adev; > > - return handle && ACPI_SUCCESS(acpi_bus_get_device(handle, &adev)) ? > - adev : NULL; > + return handle && !acpi_bus_get_device(handle, &adev) ? adev : NULL; > } > > /** -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
