RE: [PATCH v7 2/3] aerdrv: Enhanced AER logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +	char *prefix = NULL;
> 
> What are you doing here? You dropped the 'prefix' argument being passed
> down in this function and are defining a local variable of the same
> name
> which is used in the function later:
> 
>         printk("%s""aer_status: 0x%08x, aer_mask: 0x%08x\n",
>                prefix, status, mask);
> 

Boris,

I removed the prefix argument because it was never used by its caller and never set.  The reason I added the prefix variable and set it to NULL was to help in breaking up the patch and adding it would help the intermittent patch build without changing too much code.   I knew I was actually going to use the variable in patch 3. 

Lance

��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux