On Thursday, November 29, 2012 04:25:20 PM Shuah Khan wrote: > On Thu, Nov 29, 2012 at 4:10 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > During resume from system suspend the 'data' field of > > struct pnp_dev in pnpacpi_set_resources() may be a stale pointer, > > due to removal of the associated ACPI device node object in the > > previous suspend-resume cycle. This happens, for example, if a > > dockable machine is booted in the docking station and then suspended > > and resumed and suspended again. If that happens, > > pnpacpi_build_resource_template() called from pnpacpi_set_resources() > > attempts to use that pointer and crashes. > > > > However, pnpacpi_set_resources() actually checks the device's ACPI > > handle, attempts to find the ACPI device node object attached to it > > and returns an error code if that fails, so in fact it knows what the > > correct value of dev->data should be. Use this observation to update > > dev->data with the correct value if necessary and dump a call trace > > if that's the case (once). > > > > We still need to fix the root cause of this issue, but preventing > > systems from crashing because of it is an improvement too. > > > > Reported-and-tested-by: Zdenek Kabelac <zdenek.kabelac@xxxxxxxxx> > > References: https://bugzilla.kernel.org/show_bug.cgi?id=51071 > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Any reason why this shouldn't go into stable releases? Yes, it can go to -stable. This is just a patch, not a git commit. I can still add the "stable" tag to it when it goes to git. :-) Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
