Re: [PATCH] ACPI: remove unnecessary INIT_LIST_HEAD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, November 27, 2012 12:05:55 PM Westerberg, Mika wrote:
> On Tue, Nov 27, 2012 at 11:49:21AM +0200, Andy Shevchenko wrote:
> > On Tue, 2012-11-27 at 11:24 +0200, Westerberg, Mika wrote: 
> > > On Tue, Nov 27, 2012 at 11:03:45AM +0200, Andy Shevchenko wrote:
> > > > There is no need to initialize the node before appending it to the list.
> > > 
> > > I might be missing something but why do we then have macros like:
> > > list_del_init() etc?
> > 
> > list_del_init(&list->node) allows to reuse &list->node as a new list.
> > I guess the often use case of that when you extract the leaf node from
> > the list of lists and create a new list based on it.
> > 
> > In our case we just add a node to the existed list.
> 
> OK. Thanks for the explanation.
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Applied.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux