On Wednesday, November 21, 2012 12:53:55 PM Joe Perches wrote: > On Wed, 2012-11-21 at 21:50 +0100, Rafael J. Wysocki wrote: > > On Wednesday, November 21, 2012 05:46:04 AM Joe Perches wrote: > > > On Wed, 2012-11-21 at 16:43 +0800, Daniel J Blueman wrote: > > > > Previously a new line is implicitly added in the no GSI case: > > > > > > > > [ 7.185182] pci 0001:00:12.0: can't derive routing for PCI INT A > > > > [ 7.191352] pci 0001:00:12.0: PCI INT A: no GSI > > > > [ 7.195956] - using ISA IRQ 10 > > > > > > > > The code thus prints a blank line where no legacy IRQ is available: > > > > > > > > [ 1.650124] pci 0000:00:14.0: can't derive routing for PCI INT A > > > > [ 1.650126] pci 0000:00:14.0: PCI INT A: no GSI > > > > [ 1.650126] > > > > [ 1.650180] pci 0000:00:14.0: can't derive routing for PCI INT A > > > > > > > > Fix this by making the newline explicit and removing the superfluous > > > > one. > > > > > > This breaks the logging code below it when there is an ISA irq. > > > > > > The below works, but is a workaround for a defect in the printk > > > subsystem introduced by a logging change that will be fixed in > > > a near future release. > > > > What exactly do you mean by "near future"? > > I mean Jan Schönherr's patches that should fix this are > likely to be picked up one day. > > https://lkml.org/lkml/2012/11/13/678 Till then, we need the patch you sent, right? And it won't hurt to apply it anyway? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
