On Tue, 2012-11-20 at 16:01 -0800, Joe Perches wrote: > On Tue, 2012-11-20 at 16:42 -0700, Toshi Kani wrote: > > This patch introduces acpi_handle_<level>(), where <level> is > > a kernel message level such as err/warn/info, to support improved > > logging messages for ACPI, esp. hot-plug operations. > > acpi_handle_<level>() appends "ACPI" prefix and ACPI object path > > to the messages. This improves diagnosis of hotplug operations > > since an error message in a log file identifies an object that > > caused an issue. This interface acquires the global namespace > > mutex and is not suitable for interrupt context. > > Old commit log? Maybe edit out the unsuitable for interrupt > to "shows n/a in interrupt"? Hi Joe, I changed the descriptions from "may not be called from interrupt context" to "is not suitable for interrupt context". But, I agree with you that it is clear to state how the interface behaves in interrupt context. So, I will update the description to the following: "This interface acquires the global namespace mutex to obtain an object path. In interrupt context, it shows the object path as <n/a>." Hi Rafael, Instead of sending the whole series again, I will only send an updated patch 1/5 since it only updates its descriptions. The updated patch will be labeled as "[PATCH v7-1 1/5]". Thanks, -Toshi > diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c [] > + > +/** > + * acpi_handle_printk: Print message with ACPI prefix and object path > + * > + * This function is called through acpi_handle_<level> macros and prints > + * a message with ACPI prefix and object path. This function acquires > + * the global namespace mutex and is not suitable for interrupt context. Old text here too? > diff --git a/include/linux/acpi.h b/include/linux/acpi.h [] > +/* > + * acpi_handle_<level>: Print message with ACPI prefix and object path > + * > + * These interfaces acquire the global namespace mutex and are not > + * suitable for interrupt context. Here three? -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
