2012/11/17 Rafael J. Wysocki <rjw@xxxxxxx>: > On Saturday, November 17, 2012 06:33:03 PM Akinobu Mita wrote: >> Replace homemade hamming weight function with hweight8() and hweight16(). >> >> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> >> Cc: Len Brown <lenb@xxxxxxxxxx> >> Cc: Rafael J. Wysocki <rjw@xxxxxxx> >> Cc: linux-acpi@xxxxxxxxxxxxxxx > > Normally, it would be a good change, but in the case of ACPICA it is not. > > ACPICA is a separate project, which is used by multiple other operating > system (basically everyone except for Windows) and we take that code > from the ACPICA upstream. If we make changes like this in the kernel > alone, we'll start to diverge from the upstream which is not a good thing. > We've done it for a few times and we're still feeling the pain. > > The right approach to do this change would be to modify the ACPICA upstream > so that it uses OS-provided bit-counting primitives, if available. I'm > not sure if it's worth it, though. Thanks for the explanation. I fully understood. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
