On Thu, 2012-11-15 at 16:32 +0800, Hongbo Zhang wrote: > On 15 November 2012 16:13, Zhang Rui <rui.zhang@xxxxxxxxx> wrote: > > On Fri, 2012-11-09 at 19:29 +0800, hongbo.zhang wrote: > >> From: "hongbo.zhang" <hongbo.zhang@xxxxxxxxxx> > >> > >> This driver is based on the thermal management framework in thermal_sys.c. A > >> thermal zone device is created with the trip points to which cooling devices > >> can be bound, the current cooling device is cpufreq, e.g. CPU frequency is > >> clipped down to cool the CPU, and other cooling devices can be added and bound > >> to the trip points dynamically. The platform specific PRCMU interrupts are > >> used to active thermal update when trip points are reached. > >> > >> Signed-off-by: hongbo.zhang <hongbo.zhang@xxxxxxxxxx> > >> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> > >> Reviewed-by: Francesco Lavra <francescolavra.fl@xxxxxxxxx> > > > >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > >> index e1cb6bd..54c8fd0 100644 > >> --- a/drivers/thermal/Kconfig > >> +++ b/drivers/thermal/Kconfig > >> @@ -31,6 +31,26 @@ config CPU_THERMAL > >> and not the ACPI interface. > >> If you want this support, you should say Y here. > >> > >> +config DB8500_THERMAL > >> + bool "DB8500 thermal management" > > > > why is this bool? > > platform specific PRCMU interfaces are used, and those interfaces are > not exported, so my driver cannot be compiled as a module. > ok. But I still alway get this error message when set DB8500_THERMAL, include/linux/mfd/dbx500-prcmu.h:459:19: error: redefinition of ‘prcmu_abb_read’ include/linux/mfd/db8500-prcmu.h:673:19: note: previous definition of ‘prcmu_abb_read’ was here include/linux/mfd/dbx500-prcmu.h:464:19: error: redefinition of ‘prcmu_abb_write’ include/linux/mfd/db8500-prcmu.h:678:19: note: previous definition of ‘prcmu_abb_write’ was here include/linux/mfd/dbx500-prcmu.h:475:19: error: redefinition of ‘prcmu_config_clkout’ include/linux/mfd/db8500-prcmu.h:643:19: note: previous definition of ‘prcmu_config_clkout’ was here include/linux/mfd/dbx500-prcmu.h:537:19: error: redefinition of ‘prcmu_ac_wake_req’ include/linux/mfd/db8500-prcmu.h:683:19: note: previous definition of ‘prcmu_ac_wake_req’ was here include/linux/mfd/dbx500-prcmu.h:542:20: error: redefinition of ‘prcmu_ac_sleep_req’ include/linux/mfd/db8500-prcmu.h:688:20: note: previous definition of ‘prcmu_ac_sleep_req’ was here $ grep prcmu_abb_read include/linux/mfd/* include/linux/mfd/db8500-prcmu.h:int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); include/linux/mfd/db8500-prcmu.h:static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size) include/linux/mfd/dbx500-prcmu.h:int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size); include/linux/mfd/dbx500-prcmu.h:static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size) this functions are defined in both db8500-prmcu.h and dbx500-prcmu.h, plus linux/mfd/dbx500-prcmu.h includes linux/mfd/db8500-prcmu.h. I do not know how it works before, but this is a bug to me. thanks, rui -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
