On 2012/11/4 23:09, Lan Tianyu wrote:
On 2012/11/3 4:11, Rafael J. Wysocki wrote:
}
> >> EXPORT_SYMBOL_GPL(dev_pm_qos_expose_flags);
> >>@@ -645,7 +649,9 @@ void dev_pm_qos_hide_flags(struct device *dev)
> >> {
> >> if (dev->power.qos && dev->power.qos->flags_req) {
> >> pm_qos_sysfs_remove_flags(dev);
> >>+ pm_runtime_get_sync(dev);
> >> __dev_pm_qos_drop_user_request(dev, DEV_PM_QOS_FLAGS);
> >>+ pm_runtime_put(dev);
> >
> >I'm not sure if these two are necessary. If we remove a request,
> >then what happens worst case is that some flags will be cleared
> >effectively which means fewer restrictions on the next sleep state.
> >Then, it shouldn't hurt that the current sleep state is more
> >restricted.
>
>But this mean the device can be put into lower power state(power off).
>So why not do that? that can save more power, right?
Correct. On the other hand, though, if the device already is in the
deepest low-power state available, we will resume it unnecessarily this
way. Which may not be a big deal, however, and since we do that in other
cases, we may as well do it here.
Yeah. This seems not very reasonable. But we can optimize this
later.From my previous opinion, add notifier for flags and let device
driver or bus driver to determine when the device should be resumed.
Since you said at another email you would remove all notifiers in the pm
qos to make some functions able to be invoked in interrupt context. I
have a thought that check the context before call notifiers chain. If it
was in interrupt, not call notifier chain and trigger a work queue or
other choices to do that. If not, call the chain. Does this make sense? :)
Hi Rafael:
Do you have some opinions?
Thanks,
Rafael
--
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
