Re: [PATCH 1/5] cpuidle / ACPI : remove unused definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, October 19, 2012 11:51:28 AM Daniel Lezcano wrote:
> The different definitions are not used anywhere in the code.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

If you tried to build the kernel with this patch applied, I wonder
what .config you used. :-)

It doesn't build for me, because _COMPONENT is actually used.

And in the future, please check the *code* in addition to build-testing.

Thanks,
Rafael


> ---
>  drivers/acpi/processor_idle.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index e8086c7..1f536a3 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -60,14 +60,7 @@
>  #include <asm/processor.h>
>  
>  #define PREFIX "ACPI: "
> -
> -#define ACPI_PROCESSOR_CLASS            "processor"
> -#define _COMPONENT              ACPI_PROCESSOR_COMPONENT
>  ACPI_MODULE_NAME("processor_idle");
> -#define PM_TIMER_TICK_NS		(1000000000ULL/PM_TIMER_FREQUENCY)
> -#define C2_OVERHEAD			1	/* 1us */
> -#define C3_OVERHEAD			1	/* 1us */
> -#define PM_TIMER_TICKS_TO_US(p)		(((p) * 1000)/(PM_TIMER_FREQUENCY/1000))
>  
>  static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER;
>  module_param(max_cstate, uint, 0000);
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux