> > +static __initdata DECLARE_BITMAP(acpi_early_flags, > > +MAX_ACPI_DBG_PORTS*2); It's OK since the keep bit will be derived by the real earlycon drivers in the __acpi_early_console_start() which is an arch specific interface. You can find this usage in the [PATCH v6 2/2]. > > + set_bit(port, acpi_early_flags); > > + if (keep) > > + set_bit(port+MAX_ACPI_DBG_PORTS, acpi_early_flags); > Put a comment explaining why you use half of the bitmap to mark them as > 'keep'. Thought wouldn't be just easier if you had another bitmap: > acpi_keep_ports? > To set those instead of using this bitmap? I prefer to put comment here. I've been a deep embedded engineer for the last 5 years, implementing software containing 4 bus protocol stacks within 128bytes ram and 16kbytes rom, where we used high modularity design patterns. Thus made my habit being critical to ram/rom consumption... I'm OOO now, the updated version will be sent next week. Thanks for your comments and best regards/Lv Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
