On Saturday, September 29, 2012, Daniel Lezcano wrote: > On 09/29/2012 11:41 AM, Francesco Lavra wrote: > > Hi, > > Hi Francesco, > > thanks for reviewing the patch. > > >> static ssize_t show_current_driver(struct device *dev, > >> struct device_attribute *attr, > >> char *buf) > >> { > >> - ssize_t ret; > >> - struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver(); > >> + struct cbarg cbarg = { .buf = buf }; > > > > cbarg.count should be initialized to 0. > > Actually, with this initialization, all the fields will be initialized > to 0, except 'buf'. However, it would be good to initialize count explicitly so as to show that we care about the initial value of it. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html