On Thu, Sep 27, 2012 at 2:11 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> So could use assign_unassigned_bus_res pci root bus add
After your series, acpi_pci_root_start() looks like this:
pci_assign_unassigned_bus_resources
list_for_each_entry(driver, &acpi_pci_drivers, node)
driver->add(root);
pci_enable_bridges(root->bus);
so apparently it's important that the driver->add() methods be run
*before* the bridges are enabled. Why?
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> ---
> drivers/pci/probe.c | 1 +
> drivers/pci/setup-bus.c | 2 --
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 65f62e3..59cf1ba 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1905,6 +1905,7 @@ unsigned int __ref pci_rescan_bus(struct pci_bus *bus)
>
> max = pci_scan_child_bus(bus);
> pci_assign_unassigned_bus_resources(bus);
> + pci_enable_bridges(bus);
> pci_bus_add_devices(bus);
>
> return max;
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 59e6c55..6d3591d 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -1566,6 +1566,4 @@ void pci_assign_unassigned_bus_resources(struct pci_bus *bus)
> up_read(&pci_bus_sem);
> __pci_bus_assign_resources(bus, &add_list, NULL);
> BUG_ON(!list_empty(&add_list));
> -
> - pci_enable_bridges(bus);
> }
> --
> 1.7.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
