On Thu, Sep 27, 2012 at 11:23 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > On Thu, Sep 27, 2012 at 9:48 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >> On Fri, Sep 21, 2012 at 2:09 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: >>> If we get rid of the struct pci_bus * dependency, then we can easily >>> add the _PRT before doing PCI enumeration behind the bridge, and we >>> can remove the _PRT after removing the PCI devices. I think this is >>> one small step toward getting rid of the add/start and stop/remove >>> split. >> >> I'm going to work on doing this if nobody else is interested. > > I'm not sure if that is needed. That's a useless response. Do you want to elaborate on *why* you think this is a bad idea? I explained the reasons why I think it's a good idea above, but just to expand on it, we currently have to create the struct pci_bus before we can add _PRT information. But adding the _PRT info doesn't actually depend on the struct pci_bus; it only requires the segment number and the bus number. We have that information before we scan the bus . I think it's useful to disentangle _PRT interface from the specifics of PCI (in this case, the struct pci_bus). We're currently using the struct pci_bus here just as a convenient way to pass around the segment/bus number, but I don't think it's the appropriate abstraction for that. Do you see a technical problem with it? Even if it's not *necessary* in order to make host bridge hotplug work, I think it's worth doing to make the code more understandable. Do you see a problem with adding the _PRT info before scanning the bus or with removing it after deleting the bus? I'd like the bus scan code to be able to scan/add/bind drivers all at once in the PCI core. Today I think we have scan/add _PRT/device_add, where we have to do this _PRT stuff in the middle, so we have to use two PCI interfaces rather than one. It's great if you see a way to remove acpi_pci_root_start() -- that will be tremendous. I think the current PCI stop/remove split is a similar issue, and I hope you can dream up a way to consolidate those, too. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
