On Wed, Aug 29, 2012 at 10:01:36AM +0800, Aaron Lu wrote: > On Fri, Aug 24, 2012 at 03:36:21PM -0700, Joe Perches wrote: > > On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote: > > > On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote: > > > > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link > > > > devices which have _PRx, if a device does not have _PRx, a warning > > > > message will be printed. > > > > > > > > This commit is for ZPODD on Intel's platform, on AMD's platform, there > > > > is no _PRx to support ZPODD, we use _PSx. > > > > > > > > So instead of printing a useless warning message on AMD's platform, > > > > changing the print level to DEBUG to suppress this message. > > [] > > > > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c > > [] > > > > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle) > > > > return ret; > > > > > > > > no_power_resource: > > > > - printk(KERN_WARNING PREFIX "Invalid Power Resource to register!"); > > > > + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!"); > > > > Perhaps add something like: > > if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) > > printk(etc...) > > instead? > > Sorry for not describing this problem clear, this would also occur on > Intel platforms as long as that device we are calling this register > function on does not have any power resource attached to it. > > So the problem is actually, does the acpi_power_resource_register_device > function expect such input devices that they do not have any power > resource attached? If yes, then it shouldn't complain with a warning > message; if no, then we should probably check these conditions before > making such a call. > > Looking at the function itself, I think it expects such devices so a > warning message here is not appropriate. This is still present in -rc5. Linus, this message obviously warns for no good reason. Can you please pick up the patch at http://marc.info/?l=linux-kernel&m=134456468110431 since ACPI people don't seem to react here. Btw, Aaron, the stable tag should be covering 3.4 too because the patch that added the message actually is 0090def6c37c8: $ git tag --contains 0090def6c37c8 v3.4 v3.4-rc1 v3.4-rc2 v3.4-rc3 v3.4-rc4 v3.4-rc5 v3.4-rc6 v3.4-rc7 v3.4.1 v3.4.2 v3.4.3 v3.4.4 v3.4.5 v3.4.6 v3.4.7 v3.5 v3.5-rc1 v3.5-rc2 v3.5-rc3 v3.5-rc4 v3.5-rc5 v3.5-rc6 v3.5-rc7 v3.6-rc1 v3.6-rc2 v3.6-rc3 v3.6-rc4 v3.6-rc5 Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
