Hi Durga, On Tue, 11 Sep 2012 05:07:29 +0000, R, Durgadoss wrote: > In thermal_sys.c we have a CONFIG_THERMAL_HWMON. > If enabled, this creates sysfs nodes for thermal zones inside > hwmon. Do we need this functionality inside thermal_sys.c ? > Or is it Ok to remove this ? It isn't OK to remove it unless you offer an alternative implementation doing the same. The idea is that thermal zones and in particular ACPI thermal zones show up in the "sensors" command, and are thus available to monitoring applications through libsensors. If you want to remove the bridge code from thermal zones to hwmon, you must either: * Register every thermal device as a hwmon device explicitly. I don't see any point in doing that, the generic code we have today is certainly easier to maintain. * Move the generic code somewhere else. I know there have been a lot of discussions about thermal devices lately, I admit I did not follow them. If there's a better place for the generic code now, that's fine with me. * Extend libsensors to be able to deal with thermal drivers directly. If thermal devices are presented with a reasonable sysfs interface, then why not. But I'm not sure I understand what problem you are trying to solve. What's wrong with the current code? -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
