Hi Rui,
> -----Original Message-----
> From: Zhang, Rui
> Sent: Tuesday, September 11, 2012 8:51 AM
> To: R, Durgadoss
> Cc: lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; eduardo.valentin@xxxxxx
> Subject: RE: [PATCHv3 13/15] Thermal: Remove throttling logic out of
> thermal_sys.c
>
> On 一, 2012-09-10 at 21:05 -0600, R, Durgadoss wrote:
> > Hi Rui,
> >
> > > On 一, 2012-09-10 at 02:56 -0600, R, Durgadoss wrote:
> > > > Hi Rui,
> > > >
> > > > > -----Original Message-----
> > > > > From: Zhang, Rui
> > > > > Sent: Monday, September 10, 2012 2:14 PM
> > > > > To: R, Durgadoss
> > > > > Cc: lenb@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx;
> > > eduardo.valentin@xxxxxx
> > > > > Subject: Re: [PATCHv3 13/15] Thermal: Remove throttling logic out of
> > > > > thermal_sys.c
> > > > [cut.]
> > > >
> > > > > > +
> > > > > > +static void handle_non_critical_trips(struct thermal_zone_device
> *tz,
> > > > > > + int trip, enum thermal_trip_type trip_type)
> > > > > > +{
> > > > > > + tz->governor->throttle(tz, trip);
> > > > > > +}
> > > > > here is the problem, we must make sure every registered thermal
> zone
> > > > > have a governor when it is running, right?
> > > >
> > > > Yes, agree with you. Had some thoughts here, but wanted to get your
> > > opinion
> > > > before I implemented them.
> > > >
> > > > 1. We can make the default governor as 'user space', and make it load
> > > inside
> > > > thermal_sys.c (so that every zone will always have a default governor)
> > > >
> > > No, the default governor should be step wise so that it behaves the same
> > > as before. if we use userspace as default governor, most of the thermal
> > > driver will stop working with this patch set.
> >
> > yes, I understand. Shall make step_wise default, and always loaded.
> >
> we can always make step-wise default, or we can ask users to select one
> as default and load it.
Will always step_wise default. That will exactly mimic the old behavior.
will also create a new file for user space governor.
Thanks,
Durga
��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
