On Friday, September 07, 2012, Daniel Lezcano wrote:
> This variable is only used in the in processor_driver.c.
> This patch reduces the scope of the variable by moving it
> to this file.
Well, the changelog is wrong (because the scope of the variable is
not reduced by moving it out of the header) and I don't see the point.
Is there any _real_ problem with that definition in processor.h?
Rafael
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Acked-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> Tested-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> ---
> drivers/acpi/processor_driver.c | 2 +-
> include/acpi/processor.h | 1 -
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
> index bfc31cb..e1f6330 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -113,7 +113,7 @@ static struct acpi_driver acpi_processor_driver = {
>
> DEFINE_PER_CPU(struct acpi_processor *, processors);
> EXPORT_PER_CPU_SYMBOL(processors);
> -
> +extern struct cpuidle_driver acpi_idle_driver;
> struct acpi_processor_errata errata __read_mostly;
>
> /* --------------------------------------------------------------------------
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index db427fa..8b2c39a 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -332,7 +332,6 @@ int acpi_processor_power_exit(struct acpi_processor *pr,
> struct acpi_device *device);
> int acpi_processor_suspend(struct device *dev);
> int acpi_processor_resume(struct device *dev);
> -extern struct cpuidle_driver acpi_idle_driver;
>
> /* in processor_thermal.c */
> int acpi_processor_get_limit_info(struct acpi_processor *pr);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
