RE: [PATCHv2 07/14] Thermal: Update binding logic based on platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +
> > +static void __unbind(struct thermal_zone_device *tz, int mask,
> > +			struct thermal_cooling_device *cdev) {
> > +	int i;
> > +
> > +	for (i = 0; i < tz->trips; i++)
> > +		if (mask & (1 << i))
> > +			thermal_zone_unbind_cooling_device(tz, i, cdev); }
> > +
> > +static void update_bind_info(struct thermal_cooling_device *cdev) {
> 
> I do not think this function name is accurate.
> 
> Update_bind_info is called when a new cooling device comes
> and do_binding is called when a new zone is registered, right?
> I think we should reflect this in the function name.
> Maybe something like this:
> Int do_bind(tz, cdev) {
> 	If (tz->ops->bind)
> 		Tz->ops->bind(tz, cdev);
> 	Else {
> 		Blabla
> 		...
> 	}
> }
> 
> Bind_cdev(cdev) {
> 	List_for_each_entry(tz, thermal_tz_list) {
> 		 Do_bind(tz, cdev);
> 	}
> }
> 
> Bind_tz(tz) {
> 	List_for_each_entry(cdev, thermal_cdev_list) {
> 		 Do_bind(tz, cdev);
> 	}
> }
> 

Will see how I can rename/make this patch cleaner..

Thanks,
Durga
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux