> > > > #define to_cooling_device(_dev) \
> > > > @@ -1349,10 +1371,16 @@ static int retrieve_zone_params(struct
> > > > thermal_zone_device *tz)
> > > >
> > > > /* It is not an error to not have any platform data */
> > > > ret = get_platform_thermal_params(tz);
> > > > - if (ret)
> > > > + if (ret) {
> > > > tz->tzp = NULL;
> > > > + return 0;
> > > > + }
> > > >
> > > > - return 0;
> > > > + ret = device_create_file(&tz->device, &dev_attr_throttle_policy);
> > > > + if (ret)
> > > > + dev_err(&tz->device, "creating policy attr failed:%d\n",
> > > > ret);
> > > > +
> > > > + return ret;
> > > > }
> > >
> > > What does this mean?
> > > We will not create "policy" attributes if there is no
> > thermal_zone_params?
> >
> > Yes, that's what I thought initially. Because if there is no
> > 'throttle_policy'
> > we assume that it is (by default) step_wise.
> >
> > But, if we make tz_params be provided through tzd_register function
> > call, it makes sense for this to be a mandatory attribute, showing
> > 'step_wise"
> > if there is no thermal_zone_params.
> >
>
> IMO, every thermal zone should have a policy. And they can be changed
> anytime if user wants to.
Agree with you on the first part. Not sure if we want this to be writable.
Thanks,
Durga
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
