Hi Rui, Thanks for the review:) > > @@ -33,6 +33,8 @@ > > #define THERMAL_MAX_TRIPS 12 > > #define THERMAL_NAME_LENGTH 20 > > > > +#define MAX_COOLING_DEVS THERMAL_MAX_TRIPS > > + > why MAX_COOLING_DEVS equals THERMAL_MAX_TRIPS? > if this is an arbitrary number, please use the number instead, or else > this would be confusing. I wanted to use an arbitrary number, but did not have any great reason. So, thought use as many cdevs as that of the trip points. Okay, will use a number. > > > /* Initial state of a cooling device during binding */ > > #define THERMAL_NO_TARGET -1UL > > > > @@ -49,6 +51,11 @@ > > #define THERMAL_GENL_VERSION 0x01 > > #define THERMAL_GENL_MCAST_GROUP_NAME "thermal_mc_group" > > > > +/* Thermal policies */ > > +#define THERMAL_USER_SPACE 0 > > +#define THERMAL_FAIR_SHARE 1 > > +#define THERMAL_STEP_WISE 2 > > coding style. Will fix.. > > thanks, > rui ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f